Review main Abandoned

80612[FEATURE] Add new fieldControl=revealPassword option to reveal passwords

Garvin Hicking CR 0 V 0 Normal +184 −0 updated 08/23/23, 09:58

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 6

Review log 1925

  1. Garvin Hicking uploaded patch set 1 08/22/23, 07:07

  2. core-ci voted on patch set 1 V -1 08/22/23, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45662

  3. Garvin Hicking commented on patch set 1 08/22/23, 07:35

    Hm, I believe this CI output shows warnings/errors on files that my patch doesn't really influence?! Or what am I misreading?!
  4. Stefan Bürk commented on patch set 1 08/22/23, 13:13

    Reply

    Have you rebuild the javascript after the latest change in the TypeScript file ? ``` Build/Scripts/runTests.sh -s buildJavascript ``` The test basically tells us that after a build the "reveal-password.js" is changed - compiled and having a diff against the checked in file. (integration test).
  5. Stefan Bürk commented on patch set 1 08/22/23, 13:14

    Reply

    ``` HEAD detached at 6f0ca8f352 Changes to be committed: (use "git restore --staged <file>..." to unstage) modified: typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-control/reveal-password.js ```
  6. Garvin Hicking uploaded patch set 2 08/22/23, 13:20

    Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE")
  7. Garvin Hicking commented on patch set 2 08/22/23, 13:22

    Reply

    OK I see - I don't know if maybe my editor changed the auto-generated file between the build and the commit. I just re-executed the build process and re-committed the result, let me see if the Core CI is happier now. Thank your for getting in touch!
    OK I see - I don't know if maybe my editor changed the auto-generated file between the build and the commit. I just re-executed the build process and re-committed the result, let me see if the Core CI is happier now. Thank your for getting in touch!
  8. Garvin Hicking commented on patch set 2 08/22/23, 13:26

    Hm, sadly the error seems to persist, don't know what's about this `HEAD detached` output? Sadly this is my first contact with Gerrit and build pipelines like this...
  9. core-ci voted on patch set 2 V -1 08/22/23, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45684

  10. Garvin Hicking uploaded patch set 3 V -1 08/22/23, 13:42

  11. Stefan Bürk commented on patch set 3 08/22/23, 13:48

    Reply

    In hard cases, try to clean up before: ``` Build/Scripts/runTests.sh -s clean Build/Scripts/runTests.sh -s buildJavascript ``` If still not working then, let me do a repush (just ask here for it than).
  12. core-ci voted on patch set 3 V +1 08/22/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45687

  13. Andreas Kienast commented on patch set 3 CR -1 08/22/23, 14:14

    reveal-password.ts:27

    This shouldn't be required, I guess.

    reveal-password.ts:33

    Please define the explicit visibility of method (`private` fits best) and also declare an explicit return type.

    Feature-101723-RevealPasswordsViaFieldControl.rst:14

    php
  14. Garvin Hicking uploaded patch set 4 CR -1 V +1 08/22/23, 15:09

  15. Garvin Hicking commented on patch set 4 08/22/23, 15:11

    Many thanks for reviewing, I hope it's all addressed in patchset #4

    reveal-password.ts:27 Reply

    > This shouldn't be required, I guess. OK, this came from the v12 template I used as boilerplate, I see it changed in v13.

    reveal-password.ts:33 Reply

    > Please define the explicit visibility of method (`private` fits best) and also declare an explicit return type. I built this on top of a v12, where typescript wasn't yet used this way. I changed it in the new patchset, thank you for pointing it out.

    Feature-101723-RevealPasswordsViaFieldControl.rst:14 Reply

    Ack
  16. core-ci voted on patch set 4 V +1 08/22/23, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45691

  17. Garvin Hicking commented on patch set 4 08/22/23, 15:16

    Reply

    Done
    Seems to really have been caused by an uncommitted changed file, sorry for this. I am learning a lot today :-)
  18. Simon Schaufelberger commented on patch set 4 08/23/23, 07:29

    Feature-101723-RevealPasswordsViaFieldControl.rst:18

    what do you think about adding an actual code example here? that would help a lot how to use this feature.
  19. Garvin Hicking uploaded patch set 5 08/23/23, 08:47

    Copied Votes: * Verified+1 (copy condition: "changekind:NO_CHANGE")
  20. Garvin Hicking uploaded patch set 6 V +1 08/23/23, 08:47

  21. Garvin Hicking commented on patch set 4 08/23/23, 08:48

    Feature-101723-RevealPasswordsViaFieldControl.rst:18 Reply

    Sure, good suggestion, I added it (though this feature/patch has some reservations to be addressed as well)
  22. core-ci voted on patch set 6 V +1 08/23/23, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45740

  23. core-ci voted on patch set 5 V +1 08/23/23, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45739

  24. Simon Schaufelberger commented on patch set 6 08/23/23, 09:48

    Feature-101723-RevealPasswordsViaFieldControl.rst:21 Unresolved

    should be php, or?
  25. Garvin Hicking abandoned the change 08/23/23, 09:58

    Due to the implementation of passwordGenerator being available for other TCA types, this patch here is no longer needed. It is the cleaner approach to only reveal things like tokens on non-password TCA types.