Review main Merged

80613[BUGFIX] Prevent permission exception on missing files

Stefan Froemken CR +2 V +2 Easy +6 −2 updated 09/20/23, 09:39

Commit message

Deleting a missing file will not throw exception
"InsufficientFileWritePermissionsException" anymore,
as a missing file has nothing to do with insufficient
file permissions. Preventing that exception allows
calling the event "FileDeletionAspect" to remove
remaining file related records.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Froemken uploaded patch set 1 08/22/23, 08:54

  2. core-ci voted on patch set 1 V +1 08/22/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45664

  3. Jörg Bösche voted on patch set 1 CR +1 08/22/23, 11:55

  4. Benni Mack voted on patch set 1 CR +1 09/18/23, 20:57

  5. Stefan Bürk commented on patch set 2 CR +1 V +1 09/19/23, 21:20

    Published edit on patch set 1.
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 09/19/23, 21:22

  7. core-ci voted on patch set 2 V +1 09/19/23, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46832

  8. Benni Mack voted on patch set 2 V +2 CR +2 09/20/23, 09:38

  9. Benni Mack merged patch set 3 09/20/23, 09:39