Review 12.4 Merged

80614[BUGFIX] Allow a languageKey in non-Extbase f:translate VH

Christian Kuhn CR +2 V +2 Hard +254 −28 updated 08/22/23, 11:56

Commit message

Even though the <f:translate> ViewHelper has a "languageKey"
argument, the parameter was only evaluated for Extbase
requests. However, it should also be possible for non-Extbase
Fluid parts - such as Fluid emails.

The patch adds the "languageKey" handling and refactors the
tests to rely on a fixture extension. Tests are added for
"languageKey" scenarios including fallback chains.

The new tests reveal a bug in extbase LocalizationUtility with
fallback chains along the way, keeps according tests as skipped,
and adds `@todo` for further investigation.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 9