Review main Merged

80621[BUGFIX] EXT:indexed_search: Use correct API to calculate icon path

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 08/23/23, 12:02

Commit message

This patch makes use of `PathUtility::getAbsoluteWebPath()` in
EXT:indexed_search's SearchController which is suitable for calculating
asset paths in both, Composer and non-Composer scenarios.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 08/22/23, 14:08

  2. core-ci voted on patch set 1 V +1 08/22/23, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45688

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 08/22/23, 15:19

  4. Oliver Klee voted on patch set 1 CR +1 08/22/23, 19:15

  5. Benjamin Franzke voted on patch set 1 CR +1 08/23/23, 11:52

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/23/23, 11:59

  7. Benjamin Franzke merged patch set 2 08/23/23, 12:02