Review main Merged

80623[TASK] Allow passwordGenerator in all TCA types

Garvin Hicking CR +2 V +2 Easy +7 −8 updated 08/23/23, 10:13

Commit message

FormEngine fieldControl "passwordGenerator" can be
handy with TCA type="input" as well.

The patch removes a restriction in PasswordGenerator
that binds this fieldControl exclusively to TCA
type="password".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 912

  1. Garvin Hicking uploaded patch set 1 08/23/23, 06:40

  2. Garvin Hicking commented on patch set 1 08/23/23, 06:40

    Alternate approach to https://review.typo3.org/c/Packages/TYPO3.CMS/+/80595 - as discussed.
  3. core-ci voted on patch set 1 V +1 08/23/23, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45699

  4. Garvin Hicking uploaded patch set 2 V +1 08/23/23, 06:53

  5. core-ci voted on patch set 2 V +1 08/23/23, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45705

  6. Christian Kuhn uploaded patch set 3 V +1 08/23/23, 08:05

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 08/23/23, 08:06

  8. core-ci voted on patch set 3 V +1 08/23/23, 08:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45738

  9. Garvin Hicking commented on patch set 3 V +1 CR +1 08/23/23, 08:38

    Ah, I see. That's clearer instructions at a better plce, yes. :-)
  10. Stefan Bürk voted on patch set 3 V +1 CR +1 08/23/23, 10:04

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 08/23/23, 10:13

  12. Christian Kuhn merged patch set 4 08/23/23, 10:13