Review main Merged

80662[BUGFIX] Continue loop in case binary was not found

Jochen Roth CR +2 V +2 Easy +2 −2 updated 08/23/23, 19:02

Commit message

The change introduced with #101444 broke
the binary finder mechanims.

This has been fixed by "continue" the loop
instead of "break" the loop. So all paths are
tested instead of just the first one.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Jochen Roth uploaded patch set 1 08/23/23, 18:28

  2. core-ci voted on patch set 1 V +1 08/23/23, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45765

  3. Christian Kuhn updated the commit message in patch set 2 V +1 08/23/23, 18:40

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 08/23/23, 18:40

  5. core-ci voted on patch set 2 V +1 08/23/23, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45766

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 08/23/23, 18:53

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 08/23/23, 19:02

  8. Christian Kuhn merged patch set 3 08/23/23, 19:02