Review main Merged

80666[BUGFIX] Fix several undefined array key issues in DataHandler scope

Oliver Hader CR +2 V +2 Easy +8 −7 updated 08/30/23, 08:37

Commit message

DataMapProcessor tries to access `$possibleChainedIds[0]` which
might not be defined, since that array is the result of a previous
`array_intersect` invokation, which keeps the array keys of the
original input array.

DataHandler tries to access `$this->copyMappingArray[$table][$uid]`,
which might not be defined in case the previous copy command could
not be executed (e.g. since the record was deleted already).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1215

  1. Oliver Hader uploaded patch set 1 08/24/23, 11:12

  2. Frank Nägler commented on patch set 1 08/24/23, 11:18

    DataMapProcessor.php:1049

    Comment removed by: Oliver Hader; Reason: ...
  3. core-ci voted on patch set 1 V +1 08/24/23, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45783

  4. Oliver Hader commented on patch set 1 08/24/23, 11:19

    DataMapProcessor.php:1049 Reply

    Comment removed by: Oliver Hader; Reason: ...
  5. Frank Nägler commented on patch set 1 08/24/23, 11:21

    DataMapProcessor.php:1049 Reply

    Comment removed by: Oliver Hader; Reason: ...
  6. Oliver Hader uploaded patch set 2 V +1 08/24/23, 16:27

  7. Oliver Hader marked it ready for review 08/24/23, 16:28

  8. core-ci voted on patch set 2 V -1 08/24/23, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45791

  9. Christian Kuhn uploaded patch set 3 V -1 08/30/23, 00:17

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 08/30/23, 00:17

  11. core-ci voted on patch set 3 V +1 08/30/23, 00:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46004

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 08/30/23, 05:46

  13. Oliver Klee voted on patch set 3 CR +1 08/30/23, 08:23

  14. Andreas Kienast voted on patch set 3 V +2 CR +2 08/30/23, 08:37

  15. Andreas Kienast merged patch set 4 08/30/23, 08:37