Review 11.5 Merged

80669[BUGFIX] Fix several undefined array key issues in DataHandler scope

Oliver Hader CR +2 V +2 Easy +7 −6 updated 08/30/23, 08:37

Commit message

DataMapProcessor tries to access `$possibleChainedIds[0]` which
might not be defined, since that array is the result of a previous
`array_intersect` invokation, which keeps the array keys of the
original input array.

DataHandler tries to access `$this->copyMappingArray[$table][$uid]`,
which might not be defined in case the previous copy command could
not be executed (e.g. since the record was deleted already).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Oliver Hader uploaded patch set 1 08/24/23, 16:31

  2. core-ci voted on patch set 1 V -1 08/24/23, 16:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45792

  3. Andreas Kienast uploaded patch set 2 V -1 08/30/23, 06:01

  4. core-ci voted on patch set 2 V +1 08/30/23, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46013

  5. Oliver Klee voted on patch set 2 CR +1 08/30/23, 08:24

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 08/30/23, 08:37

  7. Andreas Kienast merged patch set 3 08/30/23, 08:37