Review main Merged

80671[BUGFIX] Avoid console error when tabbing through EXT:form inspector

Benjamin Franzke CR +2 V +2 Easy +4 −2 updated 08/29/23, 08:16

Commit message

…of a new form element, that has not yet been persisted.

Tabbing through an elemenet is considered an "input" by
the browser, which is why the "input" even is triggered.
The result is an empty input element (as before), but
an intent is made to delete the underlying property
from the form element object model.
When the object model is empty (remeber, it is a new element),
and an input field refers to a nested property
(e.g. properties.fluidAdditionalAttributes.placeholder)
removing an element (e.g. 'placeholder')
will fail when the parent has not yet been set
(e.g. properties.fluidAdditionalAttributes)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Benjamin Franzke uploaded patch set 1 08/25/23, 05:07

  2. core-ci voted on patch set 1 V +1 08/25/23, 05:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45818

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/25/23, 06:12

  4. Oliver Klee voted on patch set 1 CR +1 08/25/23, 06:58

  5. Christian Kuhn voted on patch set 1 V +1 08/28/23, 08:58

  6. Benjamin Kott voted on patch set 1 V +1 CR +1 08/29/23, 08:15

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/29/23, 08:16

  8. Benjamin Franzke merged patch set 2 08/29/23, 08:16