Review 11.5 Merged

80680[BUGFIX] Do not try to parse null/empty flexforms in ReferenceIndex

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 08/28/23, 10:36

Commit message

This fixes an issue in the acceptance tests where `null` is passed
to `GeneralUtility::xml2array()` (which expects a `string`).

Having an early check for an empty string also avoids
pointless XML parsing (which should help performance a bit).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 08/28/23, 10:19

    Cherry Picked from branch 12.4.
  2. core-ci voted on patch set 1 V +1 08/28/23, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45888

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 08/28/23, 10:36

  4. Christian Kuhn merged patch set 2 08/28/23, 10:36