Review 12.4 Merged

80687[TASK] Fix npm copy of contrib packages

Andreas Kienast CR +2 V +2 Easy +17 −11 updated 08/29/23, 12:57

Commit message

@lezer/common – in contrast to other @lezer modules,
is placed in dist/index.js instead of dist/index.es.js.
Therefore we add a distinct copy rule.

The sortablejs npm package recently changed to provide both,
a UMD bundle and a native ESM module.
As we actually failed to update the UMD bundle (due to a
rename of the build output filename in sortablejs),
we switch to the new ESM variant right away.

muuri failed to update because dashboardToEs6
was missing in the npmcopy concurrent target.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 4

Files 4

Review log 59

  1. Andreas Kienast commented on patch set 1 08/29/23, 12:16

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Gruntfile.js
  2. Andreas Kienast uploaded patch set 2 08/29/23, 12:19

  3. Andreas Kienast commented on patch set 2 08/29/23, 12:20

    This change is ready for review.
  4. core-ci voted on patch set 1 V -1 08/29/23, 12:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45975

  5. core-ci voted on patch set 2 V -1 08/29/23, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45976

  6. core-ci commented on patch set 2 08/29/23, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45976

  7. core-ci voted on patch set 2 V +1 08/29/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45976

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 08/29/23, 12:57

  9. Andreas Kienast merged patch set 3 08/29/23, 12:57