Review main Merged

80695[BUGFIX] Reset RteHtmlParser properly when configuration changes

Friedemann Altrock CR +2 V +2 Easy +23 −0 updated 09/01/23, 10:06

Commit message

Before this fix, only the first RTE processing configuration would be
taken into account when deciding which tags to keep in an HTML snippet.

RteHtmlParser is a DI service and as such is treated as a singleton.
Using multiple RTE processing configurations with potentially different
sets of allowed tags should work as expected.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Friedemann Altrock uploaded patch set 1 08/25/23, 15:41

  2. core-ci voted on patch set 1 V +1 08/25/23, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45835

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 09/01/23, 06:32

  4. Benjamin Franzke commented on patch set 1 09/01/23, 07:38

    Btw, thanks for your reproduction examples as github repo. That's much appreciated!
  5. Stefan Bürk commented on patch set 1 V +2 CR +2 09/01/23, 08:45

    Thanks for the effort in writing the issue and providing the github repository, and the change itself along with the test.
  6. Oliver Klee voted on patch set 1 V +1 CR +1 09/01/23, 09:09

  7. Stefan Bürk merged patch set 2 09/01/23, 10:06