Review main Merged

80697[TASK] Update PHPStan & friends

Oliver Klee CR +2 V +2 Easy +21 −21 updated 08/28/23, 08:04

Commit message

The new versions find some more possible problems,
and also improve performance.

> composer req --dev phpstan/phpstan:^1.10.32
> composer req --dev phpstan/phpstan-phpunit:^1.3.14
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Thomas Hohn +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1115

  1. Oliver Klee uploaded patch set 1 08/26/23, 06:55

  2. core-ci voted on patch set 1 V +1 08/26/23, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45845

  3. Oliver Klee uploaded patch set 2 V +1 08/26/23, 07:17

  4. core-ci voted on patch set 2 V -1 08/26/23, 07:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45846

  5. Oliver Klee commented on patch set 2 CR -1 08/26/23, 07:35

    On it.
  6. Oliver Klee uploaded patch set 3 CR -1 V -1 08/26/23, 07:36

  7. core-ci voted on patch set 3 V +1 08/26/23, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45848

  8. Benjamin Franzke commented on patch set 3 CR -1 08/26/23, 15:32

    Please either add a rationale to the commit message, why the found probably aren't fixed, but only added to the baseline. …Or even better fix them. For this case it seems the issue actually is, that array's are being converted via `assertSame` instead of `assertEquals`.
  9. Benjamin Franzke uploaded patch set 4 CR -1 V +1 08/26/23, 15:36

  10. Benjamin Franzke commented on patch set 4 08/26/23, 15:36

    Reply

    Done
  11. core-ci voted on patch set 4 V +1 08/26/23, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45860

  12. Thomas Hohn voted on patch set 4 CR +1 08/26/23, 15:51

  13. Oliver Klee commented on patch set 4 08/26/23, 15:51

    Thanks, Benjamin!
  14. Christian Kuhn voted on patch set 4 V +2 CR +2 08/28/23, 07:45

  15. Christian Kuhn merged patch set 5 08/28/23, 08:04