Review main Merged

80698[BUGFIX] Do not try to parse null/empty flexforms in ReferenceIndex

Oliver Klee CR +2 V +2 Easy +1 −1 updated 08/28/23, 10:35

Commit message

This fixes an issue in the acceptance tests where `null` is passed
to `GeneralUtility::xml2array()` (which expects a `string`).

Having an early check for an empty string also avoids
pointless XML parsing (which should help performance a bit).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Oliver Klee uploaded patch set 1 08/26/23, 07:34

  2. Oliver Klee uploaded patch set 2 08/26/23, 07:39

  3. core-ci voted on patch set 1 V +1 08/26/23, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45847

  4. core-ci voted on patch set 2 V +1 08/26/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45849

  5. Oliver Klee updated the commit message in patch set 3 V +1 08/26/23, 07:52

  6. core-ci voted on patch set 3 V +1 08/26/23, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45850

  7. Oliver Klee rebased onto patch set 4 V +1 08/28/23, 08:12

  8. core-ci voted on patch set 4 V +1 08/28/23, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45875

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 08/28/23, 10:17

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 08/28/23, 10:18

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 08/28/23, 10:35

  12. Christian Kuhn merged patch set 5 08/28/23, 10:35