Review main Merged

80709[BUGFIX] Correct fetching of extension form definitions

Benjamin Kott CR +2 V +2 Easy +6 −6 updated 08/28/23, 10:47

Commit message

The `retrieveYamlFilesFromExtensionFolders` function returned
the full path to the form configuration as key and the filename
as value. The filename used to `loadMetaData` that resulted in
that the file could not be found because it expects to get the
full path here.

We are adapting retrieveYamlFilesFromExtensionFolders so
we only work on the values returned from that array to avoid
confusions or misshaps like this in the future.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Benjamin Kott uploaded patch set 1 08/28/23, 09:13

  2. Benjamin Franzke voted on patch set 1 V +1 CR +1 08/28/23, 09:19

  3. core-ci voted on patch set 1 V +1 08/28/23, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45880

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 08/28/23, 09:24

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/28/23, 10:47

  6. Benjamin Franzke merged patch set 2 08/28/23, 10:47