Review 11.5 Merged

80733[BUGFIX] Avoid console error when tabbing through EXT:form inspector

Benjamin Franzke CR +2 V +2 Easy +3 −1 updated 08/29/23, 08:17

Commit message

…of a new form element, that has not yet been persisted.

Tabbing through an elemenet is considered an "input" by
the browser, which is why the "input" even is triggered.
The result is an empty input element (as before), but
an intent is made to delete the underlying property
from the form element object model.
When the object model is empty (remeber, it is a new element),
and an input field refers to a nested property
(e.g. properties.fluidAdditionalAttributes.placeholder)
removing an element (e.g. 'placeholder')
will fail when the parent has not yet been set
(e.g. properties.fluidAdditionalAttributes)

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benjamin Franzke uploaded patch set 1 08/28/23, 15:02

  2. core-ci voted on patch set 1 V +1 08/28/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45921

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 08/29/23, 08:17

  4. Benjamin Franzke merged patch set 2 08/29/23, 08:17