Review main Merged

80736[TASK] Define readonly for never-written private TypeScript variables

Benjamin Franzke CR +2 V +2 Hard +272 −271 updated 08/29/23, 10:44

Commit message

IDEs like PhpSstorm complain about the same thing,
so better we have that defined and checked via CI.

Commands executed:
  node_modules/.bin/eslint --fix Sources/TypeScript/

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 96

Show 76 more files

Review log 813

  1. Benjamin Franzke uploaded patch set 1 08/28/23, 16:48

  2. core-ci voted on patch set 1 V -1 08/28/23, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45929

  3. core-ci commented on patch set 1 08/28/23, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45929

  4. Benjamin Franzke uploaded patch set 2 V -1 08/28/23, 18:11

  5. core-ci voted on patch set 2 V -1 08/28/23, 18:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45937

  6. Benjamin Franzke uploaded patch set 3 V -1 08/28/23, 20:28

  7. core-ci voted on patch set 3 V -1 08/28/23, 20:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45942

  8. Benjamin Franzke rebased onto patch set 4 V -1 08/28/23, 20:41

  9. core-ci voted on patch set 4 V +1 08/28/23, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45946

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 08/29/23, 06:52

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 08/29/23, 09:19

  12. Benjamin Franzke voted on patch set 4 V +2 CR +2 08/29/23, 10:05

  13. Benjamin Franzke merged patch set 5 08/29/23, 10:44