Review main Merged

80742[TASK] Use URL API in Install Tool router

Andreas Kienast CR +2 V +2 Easy +12 −14 updated 08/29/23, 09:38

Commit message

The Install Tool router attempts to build URLs manually by wild string
replacements and manipulation, which is rather error-prone. This patch
changes the approach to use the URL API instead.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 710

  1. Andreas Kienast uploaded patch set 1 08/29/23, 08:41

  2. Benjamin Franzke voted on patch set 1 CR +1 08/29/23, 08:47

  3. core-ci voted on patch set 1 V +1 08/29/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45954

  4. Benjamin Franzke uploaded patch set 2 CR +1 V +1 08/29/23, 08:56

  5. core-ci voted on patch set 2 V -1 08/29/23, 09:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45956

  6. Benjamin Franzke uploaded patch set 3 CR +1 V +1 08/29/23, 09:06

  7. core-ci voted on patch set 3 V +1 08/29/23, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45959

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/29/23, 09:31

  9. Benjamin Franzke voted on patch set 3 V +2 CR +2 08/29/23, 09:38

  10. Benjamin Franzke merged patch set 4 08/29/23, 09:38