Review 12.4 Merged

80747[TASK] Define readonly for never-written private TypeScript variables

Benjamin Franzke CR +2 V +2 Hard +284 −283 updated 08/29/23, 10:44

Commit message

IDEs like PhpSstorm complain about the same thing,
so better we have that defined and checked via CI.

Commands executed:
  node_modules/.bin/eslint --fix Sources/TypeScript/

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 100

Show 80 more files

Review log 23

  1. Benjamin Franzke uploaded patch set 1 08/29/23, 10:08

  2. core-ci voted on patch set 1 V +1 08/29/23, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45972

  3. Benjamin Franzke merged patch set 2 08/29/23, 10:44