Review main Merged

80754[TASK] Use `requestSubmit()` in FormEngine

Andreas Kienast CR +2 V +2 Easy +2 −15 updated 08/30/23, 15:12

Commit message

FormEngine JavaScript now uses `requestSubmit()` to announce an actual
data-changing submit action which allows binding to the `submit` event.
Also, this allows some refactorings in the future.

In the past, an artifical `dispatchSubmitEvent()` method was used to
achieve the same, that is now removed.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Andreas Kienast uploaded patch set 1 08/30/23, 09:16

  2. core-ci voted on patch set 1 V +1 08/30/23, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46024

  3. Stefan Bürk voted on patch set 1 CR +1 08/30/23, 09:32

  4. Thomas Hohn voted on patch set 1 CR +1 08/30/23, 09:47

  5. Andreas Kienast commented on patch set 1 CR -1 08/30/23, 09:58

    need to check something
  6. Andreas Kienast uploaded patch set 2 CR +1 V +1 08/30/23, 10:08

  7. core-ci voted on patch set 2 V -1 08/30/23, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46029

  8. Andreas Kienast uploaded patch set 3 V -1 08/30/23, 10:28

  9. core-ci voted on patch set 3 V +1 08/30/23, 10:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46030

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 08/30/23, 15:12

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 08/30/23, 15:12

  12. Stefan Bürk merged patch set 4 08/30/23, 15:12