80761[TASK] Migrate @typo3/t3editor/stream-parser/typoscript to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/TypeScript/t3editor/language/typoscript.ts+5 −2
- Build/Sources/TypeScript/t3editor/stream-parser/typoscript.ts8new+1608 −0
- Build/types/TYPO3/index.d.ts+0 −2
- typo3/sysext/t3editor/Resources/Public/JavaScript/language/typoscript.js+1 −1
- typo3/sysext/t3editor/Resources/Public/JavaScript/stream-parser/typoscript.js+13 −1756
Review log 1923
-
Benjamin Franzke uploaded patch set 1 08/30/23, 15:25
git mv -
Benjamin Franzke uploaded patch set 2 08/30/23, 15:25
Apply eslint fix -
Benjamin Franzke uploaded patch set 3 08/30/23, 15:25
Manual eslint fixes -
Benjamin Franzke uploaded patch set 4 08/30/23, 15:26
Define types -
Benjamin Franzke uploaded patch set 5 08/30/23, 15:26
Remove unneeded jsparser code -
core-ci voted on patch set 4 V +1 08/30/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46048
-
core-ci voted on patch set 5 V +1 08/30/23, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46050
-
Andreas Kienast commented on patch set 5 08/31/23, 06:43
typoscript.ts:1122Why not `const`?typoscript.ts:1528You could return this directly. -
Andreas Kienast commented on patch set 5 08/31/23, 07:08
typoscript.ts:1607This method is not used. -
Andreas Kienast commented on patch set 5 08/31/23, 07:09
typoscript.ts:1619This is also unused, apparently. -
Benjamin Franzke uploaded patch set 6
V +108/31/23, 07:46 -
Benjamin Franzke commented on patch set 6 08/31/23, 07:46
typoscript.ts:1122ReplyGood question, I think it was used in method that were placed "behind", but I moved them in the meantime. Changed to const. Thanks!typoscript.ts:1528ReplyDonetyposcript.ts:1607ReplyDonetyposcript.ts:1619Replyugh, thanks, I wanted to remove that, as I moved the creation into t3editor/language/typoscript.ts. Done. -
Benjamin Franzke commented on patch set 6 CR -1 08/31/23, 07:47
compile went wrong -
Benjamin Franzke uploaded patch set 7
CR -108/31/23, 07:49Reset assets -
Benjamin Franzke commented on patch set 7 08/31/23, 07:49
Reply
Resolved. -
core-ci voted on patch set 6 V -1 08/31/23, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46066
-
core-ci voted on patch set 7 V +1 08/31/23, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46067
-
Benni Mack voted on patch set 7 CR +1 09/03/23, 21:42
-
Andreas Kienast voted on patch set 7 V +1 CR +1 09/04/23, 07:17
-
Stefan Bürk commented on patch set 7 CR -1 09/05/23, 12:37
reviewing ... -
Stefan Bürk voted on patch set 7 V +1 CR +1 09/05/23, 12:43
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 09/05/23, 14:08
-
Benjamin Franzke merged patch set 8 09/05/23, 14:08