Review main Merged

80761[TASK] Migrate @typo3/t3editor/stream-parser/typoscript to TypeScript

Benjamin Franzke CR +2 V +2 Nightmare +1627 −1761 updated 09/05/23, 14:08

Commit message

The parser originates from the original codemirror javascript-mode
and therefore contains a lot of legacy and unneeded code.
Code that is obviously unneded for TypoScript (like
backticks (called "quasi") or function expressions are removed
to reduce the amount of code that needs to be type-declared.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1923

  1. Benjamin Franzke uploaded patch set 1 08/30/23, 15:25

    git mv
  2. Benjamin Franzke uploaded patch set 2 08/30/23, 15:25

    Apply eslint fix
  3. Benjamin Franzke uploaded patch set 3 08/30/23, 15:25

    Manual eslint fixes
  4. Benjamin Franzke uploaded patch set 4 08/30/23, 15:26

    Define types
  5. Benjamin Franzke uploaded patch set 5 08/30/23, 15:26

    Remove unneeded jsparser code
  6. core-ci voted on patch set 4 V +1 08/30/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46048

  7. core-ci voted on patch set 5 V +1 08/30/23, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46050

  8. Andreas Kienast commented on patch set 5 08/31/23, 06:43

    typoscript.ts:1122

    Why not `const`?

    typoscript.ts:1528

    You could return this directly.
  9. Andreas Kienast commented on patch set 5 08/31/23, 07:08

    typoscript.ts:1607

    This method is not used.
  10. Andreas Kienast commented on patch set 5 08/31/23, 07:09

    typoscript.ts:1619

    This is also unused, apparently.
  11. Benjamin Franzke uploaded patch set 6 V +1 08/31/23, 07:46

  12. Benjamin Franzke commented on patch set 6 08/31/23, 07:46

    typoscript.ts:1122 Reply

    Good question, I think it was used in method that were placed "behind", but I moved them in the meantime. Changed to const. Thanks!

    typoscript.ts:1528 Reply

    Done

    typoscript.ts:1607 Reply

    Done

    typoscript.ts:1619 Reply

    ugh, thanks, I wanted to remove that, as I moved the creation into t3editor/language/typoscript.ts. Done.
  13. Benjamin Franzke commented on patch set 6 CR -1 08/31/23, 07:47

    compile went wrong
  14. Benjamin Franzke uploaded patch set 7 CR -1 08/31/23, 07:49

    Reset assets
  15. Benjamin Franzke commented on patch set 7 08/31/23, 07:49

    Reply

    Resolved.
  16. core-ci voted on patch set 6 V -1 08/31/23, 07:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46066

  17. core-ci voted on patch set 7 V +1 08/31/23, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46067

  18. Benni Mack voted on patch set 7 CR +1 09/03/23, 21:42

  19. Andreas Kienast voted on patch set 7 V +1 CR +1 09/04/23, 07:17

  20. Stefan Bürk commented on patch set 7 CR -1 09/05/23, 12:37

    reviewing ...
  21. Stefan Bürk voted on patch set 7 V +1 CR +1 09/05/23, 12:43

  22. Benjamin Franzke voted on patch set 7 V +2 CR +2 09/05/23, 14:08

  23. Benjamin Franzke merged patch set 8 09/05/23, 14:08