80765[TASK] Add CI check for zero stray or non updated JavaScript files
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 5
Files 1
Review log 1519
-
Benjamin Franzke uploaded patch set 1 08/30/23, 20:20
-
core-ci voted on patch set 1 V -1 08/30/23, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46059
-
Benjamin Franzke commented on patch set 1 08/31/23, 04:14
typo here, will fix -
Benjamin Franzke uploaded patch set 2
V -109/05/23, 14:10 -
Benjamin Franzke updated the commit message in patch set 3 09/05/23, 14:10
-
Benjamin Franzke commented on patch set 3 09/05/23, 14:10
Reply
Done -
core-ci voted on patch set 3 V +1 09/05/23, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46239
-
Benjamin Franzke commented on patch set 3 09/05/23, 14:36
Information for reviewers: Please check the CI run of patchset 1 in comparison to patchset 3, it shows how CI will report stray files (readable as `git status` output). -
Andreas Kienast commented on patch set 3 09/05/23, 15:21
runTests.sh:724Do we need the output here again? AFAICS it's already executed before. -
Benjamin Franzke uploaded patch set 4
V +109/05/23, 18:40 -
Benjamin Franzke commented on patch set 4 09/05/23, 18:40
runTests.sh:724Replyoops, right, i've overseen that `git status` was already invoked twice. Thanks! Fixed. -
core-ci voted on patch set 4 V +1 09/05/23, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46253
-
Andreas Kienast updated the commit message in patch set 5
V +109/06/23, 11:55 -
Andreas Kienast voted on patch set 5 V +1 CR +1 09/06/23, 11:58
-
core-ci voted on patch set 5 V +1 09/06/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46291
-
Stefan Bürk voted on patch set 5 V +1 CR +1 09/06/23, 20:02
-
Oliver Klee voted on patch set 5 V +1 CR +1 09/06/23, 22:13
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 09/07/23, 04:25
-
Anja Leichsenring merged patch set 6 09/07/23, 04:25