Review main Merged

80765[TASK] Add CI check for zero stray or non updated JavaScript files

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 09/07/23, 04:25

Commit message

All in-tree .js files have been migrated to TypeScript, so it's
time to add a CI check to ensure no stray build files (see #101786)
or non-updated JavaScript files (e.g. #101784, #101785, #101787)
are present in the git tree.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 5

Files 1

Review log 1519

  1. Benjamin Franzke uploaded patch set 1 08/30/23, 20:20

  2. core-ci voted on patch set 1 V -1 08/30/23, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46059

  3. Benjamin Franzke commented on patch set 1 08/31/23, 04:14

    typo here, will fix
  4. Benjamin Franzke uploaded patch set 2 V -1 09/05/23, 14:10

  5. Benjamin Franzke updated the commit message in patch set 3 09/05/23, 14:10

  6. Benjamin Franzke commented on patch set 3 09/05/23, 14:10

    Reply

    Done
  7. core-ci voted on patch set 3 V +1 09/05/23, 14:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46239

  8. Benjamin Franzke commented on patch set 3 09/05/23, 14:36

    Information for reviewers: Please check the CI run of patchset 1 in comparison to patchset 3, it shows how CI will report stray files (readable as `git status` output).
  9. Andreas Kienast commented on patch set 3 09/05/23, 15:21

    runTests.sh:724

    Do we need the output here again? AFAICS it's already executed before.
  10. Benjamin Franzke uploaded patch set 4 V +1 09/05/23, 18:40

  11. Benjamin Franzke commented on patch set 4 09/05/23, 18:40

    runTests.sh:724 Reply

    oops, right, i've overseen that `git status` was already invoked twice. Thanks! Fixed.
  12. core-ci voted on patch set 4 V +1 09/05/23, 18:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46253

  13. Andreas Kienast updated the commit message in patch set 5 V +1 09/06/23, 11:55

  14. Andreas Kienast voted on patch set 5 V +1 CR +1 09/06/23, 11:58

  15. core-ci voted on patch set 5 V +1 09/06/23, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46291

  16. Stefan Bürk voted on patch set 5 V +1 CR +1 09/06/23, 20:02

  17. Oliver Klee voted on patch set 5 V +1 CR +1 09/06/23, 22:13

  18. Anja Leichsenring voted on patch set 5 V +2 CR +2 09/07/23, 04:25

  19. Anja Leichsenring merged patch set 6 09/07/23, 04:25