Review main Merged

80769[TASK] Properly disable task setting fields

Andreas Kienast CR +2 V +2 Easy +17 −16 updated 08/31/23, 13:32

Commit message

In its current implementation, the scheduler module renders all
settings fields (aka "additional fields") at one and toggles their
visibility depending of the selected scheduler task that is about to
get created.

When submitting the form, the field are now properly disabled to
prevent their submission, instead of moving the fields out of the form
in a `submit` event handler.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1012

  1. Andreas Kienast uploaded patch set 1 08/31/23, 09:05

  2. core-ci voted on patch set 1 V +1 08/31/23, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46073

  3. Benjamin Franzke commented on patch set 1 08/31/23, 10:32

    scheduler.ts:46

    That means `<div id="extraFieldsHidden"></div>` could be dropped from the markup, right?
  4. Benjamin Franzke commented on patch set 1 08/31/23, 10:32

    scheduler.ts:46 Reply

    I mean from the template in typo3/sysext/scheduler/Resources/Private/Templates/AddTaskForm.html and typo3/sysext/scheduler/Resources/Private/Templates/EditTaskForm.html
  5. Andreas Kienast commented on patch set 1 CR -1 08/31/23, 10:43

    scheduler.ts:46 Reply

    Ack
  6. Andreas Kienast uploaded patch set 2 CR -1 V +1 08/31/23, 10:45

  7. core-ci voted on patch set 2 V +1 08/31/23, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46081

  8. Benjamin Franzke voted on patch set 2 CR +1 08/31/23, 11:01

  9. Benjamin Franzke voted on patch set 2 V +1 08/31/23, 11:08

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 08/31/23, 13:31

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 08/31/23, 13:32

  12. Andreas Kienast merged patch set 3 08/31/23, 13:32