Review main Merged

80793[BUGFIX] Avoid strtotime(null) in BU::getProcessedValue()

Christian Kuhn CR +2 V +2 Normal +101 −2 updated 08/31/23, 13:52

Commit message

BackendUtility has a couple of strtotime() calls that
may end up as strtotime(null). This emits a PHP
E_DEPRECATED error since PHP 8.1. Add a cast.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 78

  1. Christian Kuhn uploaded patch set 1 08/31/23, 12:48

  2. core-ci voted on patch set 1 V +1 08/31/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46095

  3. Oliver Klee voted on patch set 1 V +1 CR +1 08/31/23, 13:18

  4. Oliver Klee commented on patch set 1 08/31/23, 13:19

    Thumbs up for directly covering this with regression tests! <3
  5. Stefan Bürk voted on patch set 1 CR +1 08/31/23, 13:25

  6. Stefan Bürk voted on patch set 1 V +1 08/31/23, 13:31

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 08/31/23, 13:52

  8. Christian Kuhn merged patch set 2 08/31/23, 13:52