Review main Merged

80815[TASK] Avoid AbstractDataHandlerActionTestCase

Christian Kuhn CR +2 V +2 Expert +615 −841 updated 09/01/23, 14:17

Commit message

Avoiding this abstract streamlines various tests to
do more things similar as other tests.

This especially affects needed site setups, which is
now done more often based on the SiteBasedTestTrait.

There is also less class state in tests, making them
more easy to understand and follow.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 09/01/23, 12:59

  2. core-ci voted on patch set 1 V +1 09/01/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46135

  3. Christian Kuhn updated the commit message in patch set 2 V +1 09/01/23, 13:15

  4. core-ci voted on patch set 2 V +1 09/01/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46136

  5. Stefan Bürk voted on patch set 2 V +1 09/01/23, 14:00

  6. Stefan Bürk voted on patch set 2 CR +1 09/01/23, 14:03

  7. Andreas Kienast voted on patch set 2 V +1 CR +1 09/01/23, 14:12

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 09/01/23, 14:17

  9. Christian Kuhn merged patch set 3 09/01/23, 14:17