Review main Merged Breaking

80819[!!!][TASK] Remove jQuery from `@typo3/backend/document-save-actions` module

Andreas Kienast CR +2 V +2 Hard +163 −100 updated 09/20/23, 15:55

Commit message

The JavaScript module `@typo3/backend/document-save-actions` is used in
FormEngine and Scheduler context mainly to disable the submit button in
the according forms, where also a spinner is rendered within the button
to visualize a running action.

Over the time, the module took over some tasks that logically belong to
FormEngine, which lead to slimming down the module. In a further effort,
jQuery has been removed from said module, leading to a change in
behavior how the callback chain can be aborted.

Native JavaScript events cannot get asked whether event propagation has
been stopped, making changes in the callbacks necessary. All callbacks
registered via `addPreSubmitCallback()` now need to return a boolean
value.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9