Review main Merged

80823[TASK] Use SiteBasedTestTrait consistently

Christian Kuhn CR +2 V +2 Nightmare +1440 −1329 updated 09/02/23, 16:29

Commit message

When the functional test related SiteBasedTestTrait
has been introduced, it was not rolled out to all
possible consumers: Some were left to write site
yaml files on their own.

The patch changes this, which especially simplifies
abstraction in "DataScenarios".

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 49

Show 29 more files

Review log 79

  1. Christian Kuhn uploaded patch set 1 09/02/23, 10:56

  2. core-ci voted on patch set 1 V +1 09/02/23, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46165

  3. Christian Kuhn uploaded patch set 2 V +1 09/02/23, 11:12

  4. core-ci voted on patch set 2 V +1 09/02/23, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46166

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 09/02/23, 11:30

  6. Oliver Klee voted on patch set 2 V +1 09/02/23, 16:00

  7. Nikita Hovratov voted on patch set 2 V +1 CR +1 09/02/23, 16:12

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 09/02/23, 16:29

  9. Stefan Bürk merged patch set 3 09/02/23, 16:29