Review main Abandoned

80825[TASK] Test core patches at T3Camp MUC

Friedemann Altrock CR 0 V 0 Easy +3 −0 updated 09/03/23, 12:34

Commit message

This is a test patch to show how core contributions work.

And here is some more detail about this commit...

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 912

  1. Friedemann Altrock uploaded patch set 1 09/03/23, 12:05

  2. Friedemann Altrock commented on patch set 1 09/03/23, 12:07

    ContentLengthResponseHeader.php:52

    This HTTP header name is not compliant with RFC XXX, maybe.
  3. Garvin Hicking commented on patch set 1 CR +1 09/03/23, 12:08

    😬
  4. Elias Häußler commented on patch set 1 V +1 CR +1 09/03/23, 12:09

    ContentLengthResponseHeader.php:52 Reply

    LGTM 🫡
  5. core-ci voted on patch set 1 V +1 09/03/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46172

  6. Stefan Bürk commented on patch set 1 09/03/23, 12:12

    ContentLengthResponseHeader.php:50

    It's not obvious what is tried to archieve with this change. Can you please give more background information in the commit message and/or issue on forge ? ;-)
  7. Friedemann Altrock uploaded patch set 2 CR +1 V +1 09/03/23, 12:13

  8. Friedemann Altrock updated the commit message in patch set 3 09/03/23, 12:20

  9. core-ci voted on patch set 2 V +1 09/03/23, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46173

  10. core-ci voted on patch set 3 V +1 09/03/23, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46174

  11. Stefan Bürk commented on patch set 3 09/03/23, 12:28

    ContentLengthResponseHeader.php:50 Reply

    Done
  12. Friedemann Altrock abandoned the change 09/03/23, 12:34

    Abandon because session is over :)