Review main Merged

80853[BUGFIX] Apply `t3js-colorpicker-initialized` class to correct element

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 09/04/23, 14:14

Commit message

Since migrating the color picker to alwan in #101646, the
`t3js-colorpicker-initialized` class is applied to the input element to
determine whether the color picker has been initialized already.

However, checking the class is done on a different element, which is a
simple left-over from the migration that is now fixed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/04/23, 13:39

  2. core-ci voted on patch set 1 V +1 09/04/23, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46193

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/04/23, 13:53

  4. Andreas Nedbal voted on patch set 1 V +1 CR +1 09/04/23, 14:04

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 09/04/23, 14:14

  6. Andreas Kienast merged patch set 2 09/04/23, 14:14