Review main Merged

80860[BUGFIX] Add missing label to modal close button

Benjamin Kott CR +2 V +2 Easy +10 −14 updated 09/05/23, 14:21

Commit message

We also ensure that TYPO3.lang checks are correct
when the modal is used in a context where TYPO3.lang
is not defined.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Benjamin Kott uploaded patch set 1 09/05/23, 08:10

  2. Benjamin Franzke voted on patch set 1 CR +1 09/05/23, 08:11

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/05/23, 08:19

  4. core-ci voted on patch set 1 V -1 09/05/23, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46217

  5. Benjamin Kott uploaded patch set 2 CR +1 V +1 09/05/23, 10:26

  6. core-ci voted on patch set 2 V +1 09/05/23, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46228

  7. Benjamin Kott uploaded patch set 3 V +1 09/05/23, 10:39

  8. core-ci voted on patch set 3 V +1 09/05/23, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46229

  9. Benjamin Franzke voted on patch set 3 V +1 CR +1 09/05/23, 11:09

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 09/05/23, 11:34

  11. Oliver Klee voted on patch set 3 CR +1 09/05/23, 13:00

  12. Stefan Bürk voted on patch set 3 V +1 CR +1 09/05/23, 13:33

  13. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/05/23, 13:59

  14. Benjamin Franzke merged patch set 4 09/05/23, 14:21