Review main Merged

80863[TASK] Allow eslint execution from root folder

Benjamin Franzke CR +2 V +2 Easy +5 −9 updated 09/05/23, 09:38

Commit message

With #101782 eslint project configuration was overwritten
to use a custom path.
eslint read the relative project configuration based
on the current execution folder instead of relative
to the eslintrc file.
This worked as long as eslint was executed from the
Build/ folder (execution folder == eslintrc folder).

As some tools execute eslint from the git root directory,
the configuration is now adapted to always resolve the
tsconfig file name as an absolute path based on the
configurations directory name.

Also overrideConfigFile is removed from Gruntfile.js
as .eslintrc.[json|js] is read by default and no
override is needed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Kienast +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 79

  1. Benjamin Franzke uploaded patch set 1 09/05/23, 08:40

  2. core-ci voted on patch set 1 V -1 09/05/23, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46221

  3. Benjamin Franzke uploaded patch set 2 V -1 09/05/23, 08:55

  4. core-ci voted on patch set 2 V +1 09/05/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46222

  5. Andreas Kienast voted on patch set 2 CR +1 09/05/23, 09:11

  6. Benjamin Kott voted on patch set 2 V +1 CR +1 09/05/23, 09:36

  7. Andreas Kienast voted on patch set 2 V +1 09/05/23, 09:37

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/05/23, 09:37

  9. Benjamin Franzke merged patch set 3 09/05/23, 09:38