Review 12.4 Merged

80867[BUGFIX] Add missing label to modal close button

Benjamin Franzke CR +2 V +2 Easy +10 −14 updated 09/05/23, 14:21

Commit message

We also ensure that TYPO3.lang checks are correct
when the modal is used in a context where TYPO3.lang
is not defined.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 09/05/23, 13:59

  2. core-ci voted on patch set 1 V +1 09/05/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46236

  3. Benjamin Franzke merged patch set 2 09/05/23, 14:21