80870[TASK] Add tests to show working regexp redirects with query parameter
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benjamin Franzke +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1924
-
Stefan Bürk uploaded patch set 1 09/05/23, 15:05
-
core-ci voted on patch set 1 V +1 09/05/23, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46244
-
Stefan Bürk updated the commit message in patch set 2
V +109/05/23, 15:14 -
Stefan Bürk uploaded patch set 3 09/05/23, 15:16
-
Oliver Klee commented on patch set 2 09/05/23, 15:18
-
Oliver Klee commented on patch set 3 09/05/23, 15:19
RedirectServiceTest.php:316Why this change? -
core-ci voted on patch set 3 V +1 09/05/23, 15:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46247
-
Stefan Bürk commented on patch set 3 09/05/23, 15:51
RedirectServiceTest.php:363ReplyAck. Had that for other test recently too. Sadly, I just copied other tests for this and not rechecking the exact assert call. -
Stefan Bürk uploaded patch set 4
V +109/05/23, 15:52 -
Stefan Bürk uploaded patch set 5 09/05/23, 15:53
-
Stefan Bürk commented on patch set 5 09/05/23, 15:54
RedirectServiceTest.php:316ReplyDoneRedirectServiceTest.php:363ReplyDone -
Stefan Bürk commented on patch set 5 09/05/23, 15:54
RedirectServiceTest.php:316ReplyLeft over. First tried to add it to that test before making two dedicated test methods. -
core-ci voted on patch set 4 V +1 09/05/23, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46250
-
core-ci voted on patch set 5 V +1 09/05/23, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46251
-
Oliver Klee voted on patch set 5 V +1 09/05/23, 17:05
-
Benjamin Franzke voted on patch set 5 V +1 CR +1 09/05/23, 22:36
-
Oliver Klee commented on patch set 5 09/06/23, 07:52
RedirectServiceTest.php:344Instead of "DoesNotRedirect" ("what does it not do"), I propose stating what it does instead: `regexpWithNoParamRegexpAndRespectingGetParameteresIssuesNotFoundStatusIfParamsAreGivenInUrl`RedirectServiceTest.php:370There's an "s" missing: `regexpWithNoParamRegexpAndRespectingGetParameteresRedirectsIfNoParamsAreGiven` -
Stefan Bürk uploaded patch set 6
CR +1V +109/06/23, 08:47 -
Stefan Bürk commented on patch set 6 09/06/23, 08:48
RedirectServiceTest.php:344ReplyDoneRedirectServiceTest.php:370ReplyDone -
Benjamin Franzke voted on patch set 6 V +1 CR +1 09/06/23, 08:51
-
Oliver Klee voted on patch set 6 V +1 CR +1 09/06/23, 08:53
-
core-ci voted on patch set 6 V +1 09/06/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46271
-
Stefan Bürk voted on patch set 6 V +2 CR +2 09/06/23, 20:13
-
Stefan Bürk merged patch set 7 09/06/23, 20:26
RedirectServiceTest.php:363