Review main Merged

80873[BUGFIX] Fix race condition in module router

Benjamin Franzke CR +2 V +2 Easy +9 −2 updated 09/07/23, 08:36

Commit message

The module components (like the iframe wrapper) are
created asynchronously after their implementing module
(e.g. <typo3-iframe-module>) is loaded.

The router had a preparatory check that verified
that existing module elements are reused, but missed
to verifiy whether the element has been created in
parallel while the module components javascript module
was loaded. This happens when the module changes
while the module component is loaded for the first time.

That leads to a situation that the module componenent
was created twice, which rendered two module frames
into the backend.

Also resolve a long overdue todo while at it.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Benjamin Franzke uploaded patch set 1 09/05/23, 20:32

  2. core-ci voted on patch set 1 V +1 09/05/23, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46258

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/07/23, 07:38

  4. Stefan Bürk voted on patch set 1 CR +1 09/07/23, 07:40

  5. Stefan Bürk voted on patch set 1 V +1 09/07/23, 07:57

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/07/23, 07:59

  7. Oliver Klee voted on patch set 1 CR +1 09/07/23, 08:28

  8. Benjamin Franzke merged patch set 2 09/07/23, 08:36