Review main Merged

80877[TASK] Make ajax-data-handler visibility toggle explicit

Benjamin Kott CR +2 V +2 Normal +109 −84 updated 09/12/23, 07:13

Commit message

Instead of parsing parameters and string replacing
parts of it we are now passing all nessesary parts
as data attributes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1723

  1. Benjamin Kott uploaded patch set 1 09/06/23, 09:12

  2. core-ci voted on patch set 1 V +1 09/06/23, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46277

  3. Benjamin Kott uploaded patch set 2 V +1 09/06/23, 09:46

  4. core-ci voted on patch set 2 V +1 09/06/23, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46281

  5. Benjamin Kott updated the commit message in patch set 3 V +1 09/06/23, 10:16

  6. core-ci voted on patch set 3 V +1 09/06/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46282

  7. Benjamin Kott rebased onto patch set 4 V +1 09/06/23, 11:47

  8. core-ci voted on patch set 4 V +1 09/06/23, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46289

  9. Benni Mack voted on patch set 4 CR +1 09/07/23, 10:57

  10. Benjamin Kott rebased onto patch set 5 CR +1 V +1 09/08/23, 12:53

  11. core-ci voted on patch set 5 V +1 09/08/23, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46390

  12. Benjamin Franzke voted on patch set 5 V +1 CR +1 09/11/23, 07:14

  13. Benjamin Kott rebased onto patch set 6 CR +1 V +1 09/11/23, 12:02

  14. core-ci voted on patch set 6 V +1 09/11/23, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46477

  15. Benjamin Franzke voted on patch set 6 V +1 CR +1 09/11/23, 12:21

  16. Georg Ringer commented on patch set 6 09/11/23, 20:03

    DatabaseRecordList.php:1543

    no need to use variable $visibleValue and $hiddenValue, the variables can be assigned directly in the array below
  17. Stefan Bürk voted on patch set 6 V +1 CR +1 09/12/23, 05:06

  18. Benjamin Kott commented on patch set 6 09/12/23, 05:38

    DatabaseRecordList.php:1543 Reply

    sure thing but it is more easy to read and understand the settings are grouped, will keep it like that for now.
  19. Benjamin Franzke voted on patch set 6 V +2 CR +2 09/12/23, 05:59

  20. Benjamin Franzke commented on patch set 6 V +1 CR -1 09/12/23, 06:06

    on hold, backport needs more time.
  21. Benjamin Franzke commented on patch set 6 09/12/23, 06:41

    Reply

    backport ready, but will only merge after todays release.
  22. Benjamin Franzke voted on patch set 6 V +2 CR +2 09/12/23, 07:13

  23. Benjamin Franzke merged patch set 7 09/12/23, 07:13