Review 12.4 Merged

80878[BUGFIX] Correct usage of GenericButton

Benjamin Franzke CR +2 V +2 Easy +6 −6 updated 09/06/23, 09:33

Commit message

The GenericButton requires a label to be set
instead of a title. The title rendering falls back
to the label if no dedicated title is provided.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 23

  1. Benjamin Franzke uploaded patch set 1 09/06/23, 09:22

  2. core-ci voted on patch set 1 V +1 09/06/23, 09:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46278

  3. Benjamin Franzke merged patch set 2 09/06/23, 09:33