Review main Merged

80879[BUGFIX] Ensure package state file using the setup command

Stefan Bürk CR +2 V +2 Easy +10 −3 updated 09/07/23, 20:32

Commit message

With #99221 the cli setup command has been introduced to
setup a instance from the command line and improved with
followup changes.

This works pretty fine in composer mode installations. In
non-composer mode installations the package state file is
not created using the cli command whereas the web based
installation process creates one.

This change ensures that a package state file is created
if none exists. If no file is found, it creates it based
on default factory settings like the installer.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Jochen Roth +1
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 1521

  1. Stefan Bürk uploaded patch set 1 09/06/23, 10:55

  2. Stefan Bürk updated the commit message in patch set 2 09/06/23, 10:57

  3. core-ci voted on patch set 1 V +1 09/06/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46284

  4. core-ci voted on patch set 2 V +1 09/06/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46285

  5. Stefan Bürk voted on patch set 2 CR -1 09/06/23, 11:10

  6. Stefan Bürk voted on patch set 2 CR -2 09/06/23, 11:10

  7. Stefan Bürk uploaded patch set 3 V +1 09/07/23, 13:48

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  8. core-ci voted on patch set 3 V -1 09/07/23, 13:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46353

  9. Stefan Bürk uploaded patch set 4 V -1 09/07/23, 14:28

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  10. core-ci voted on patch set 4 V +1 09/07/23, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46354

  11. Stefan Bürk uploaded patch set 5 V +1 09/07/23, 17:00

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  12. Stefan Bürk voted on patch set 5 CR 0 09/07/23, 17:00

  13. core-ci voted on patch set 5 V +1 09/07/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46356

  14. Helmut Hummel commented on patch set 5 V +1 CR +1 09/07/23, 17:12

    SetupCommand.php:215

    It's actually PackageStates.php file. PackageArtifact is written in/by Composer in Composer mode
  15. Stefan Bürk uploaded patch set 6 CR +1 V +1 09/07/23, 17:15

  16. Stefan Bürk commented on patch set 6 09/07/23, 17:16

    SetupCommand.php:215 Reply

    Done
  17. Helmut Hummel voted on patch set 6 V +1 CR +1 09/07/23, 17:17

  18. core-ci voted on patch set 6 V +1 09/07/23, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46357

  19. Jochen Roth voted on patch set 6 V +1 CR +1 09/07/23, 20:17

  20. Stefan Bürk voted on patch set 6 V +2 CR +2 09/07/23, 20:20

  21. Stefan Bürk merged patch set 7 09/07/23, 20:32