Review main Merged

80883[TASK] Set display fields during DatabaseRecordList start

Benjamin Kott CR +2 V +2 Easy +2 −13 updated 09/08/23, 12:39

Commit message

In order to ease the usage of DatabaseRecordList in core,
the setDisplFields() call is not needed and can be handled
within the start() method directly. The method calls
are thus removed from the calling code.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Benjamin Kott uploaded patch set 1 09/06/23, 12:57

  2. Oliver Klee commented on patch set 1 09/06/23, 13:01

    Honestly, I have no idea why this change is needed or helpful (but I trust that it is). Could you add a few words to the commit message explaining the reason for/benefit of this change? :-)
  3. Benjamin Kott uploaded patch set 2 09/06/23, 13:02

  4. core-ci voted on patch set 1 V +1 09/06/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46295

  5. core-ci voted on patch set 2 V +1 09/06/23, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46296

  6. Benni Mack updated the commit message in patch set 3 V +1 09/07/23, 22:41

  7. Benni Mack commented on patch set 3 V +1 CR +1 09/07/23, 22:41

    Reply

    Done
  8. core-ci voted on patch set 3 V +1 09/07/23, 22:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46364

  9. Oliver Klee voted on patch set 3 V +1 CR +1 09/08/23, 06:42

  10. Benjamin Kott voted on patch set 3 V +2 CR +2 09/08/23, 12:17

  11. Benjamin Kott merged patch set 4 09/08/23, 12:39