Review main Merged

80885[BUGFIX] Preserve "All languages" in page module

Nicole Hummel CR +2 V +2 Easy +9 −13 updated 01/13/25, 13:00

Commit message

A user can switch to see all languages side by side in page layout
module. Doing so will store the special language value of -1 in
their user settings. Switching to a page with no translations
does no longer reset this state.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1521

  1. Nicole Hummel uploaded patch set 1 09/06/23, 13:45

  2. Nicole Hummel updated the commit message in patch set 2 09/06/23, 13:45

  3. core-ci voted on patch set 1 V +1 09/06/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46300

  4. core-ci voted on patch set 2 V +1 09/06/23, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46301

  5. Benjamin Franzke commented on patch set 2 09/06/23, 19:25

    Thanks for the patch, we should really try to fix this. I agree that it is a pity that language state -1 is lost when switch between translated and non-translated pages. This patch is basically a revert of https://review.typo3.org/c/Packages/TYPO3.CMS/+/71173 and I'd like to verify if the issues described back then "since this led to misbehaviour, e.g. empty views in some cases." still exist. Therefore I'm cc'ing oli bartsch. What I can already say: We want the mode to preserved, yes – but we don't want the language toggle to be shown when there is actually no language switch available (so for the case when no translations exist). We should check whether we can improve this patch in that regard, to preserve the current UI as-is.
  6. Sybille Peters commented on patch set 2 04/14/24, 05:43

    Reply

    Perhaps you can also look at the extension https://github.com/Quebecca/qc_be_pagelanguage We have been using this for some time since it fixes the problem and makes behaviour similar to previous behaviour. I am not aware of any problems and so far, the benefit outweighs any problems even if there were any. Proceeding without the extension in existing sites will probably make translations less visible in a mixed site (with translations not existing for all pages).
  7. Benni Mack updated the commit message in patch set 3 V +1 10/18/24, 13:27

  8. core-ci voted on patch set 3 V -1 10/18/24, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67966

  9. Benni Mack rebased onto patch set 4 V -1 01/13/25, 11:51

  10. core-ci voted on patch set 4 V +1 01/13/25, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72327

  11. Christian Kuhn voted on patch set 4 CR +1 V +1 01/13/25, 12:09

  12. Christian Kuhn voted on patch set 4 CR 0 V 0 01/13/25, 12:12

  13. Christian Kuhn updated the commit message in patch set 5 V +1 01/13/25, 12:14

  14. core-ci voted on patch set 5 V +1 01/13/25, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72329

  15. Oli Bartsch commented on patch set 4 V -1 01/13/25, 12:26

    Reply

    Just check this and can confirm a bug. In case -1 is selected and switching to a page with no translations, language comparison is used and a language selector with no option is shown.
  16. Oli Bartsch uploaded patch set 6 V +1 01/13/25, 12:45

  17. Oli Bartsch commented on patch set 6 CR +1 V +1 01/13/25, 12:48

    Reply

    Done
  18. core-ci voted on patch set 6 V +1 01/13/25, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72332

  19. Christian Kuhn voted on patch set 6 CR +1 V +1 01/13/25, 12:53

  20. Oli Bartsch voted on patch set 6 CR +2 V +2 01/13/25, 13:00

  21. Oli Bartsch merged patch set 7 01/13/25, 13:00