Review 11.5 Merged

80886[TASK] Add tests to show working regexp redirects with query parameter

Stefan Bürk CR +2 V +2 Normal +60 −0 updated 09/06/23, 20:26

Commit message

With #101739 a bug has been reported, which is
not correct.

This change adds functional tests to `ext:redirects`
to show and cover that:

* regexp redirects with a pattern not covering params
  but query arguments are given in the request uri and
  "Respect GET Parameters" has been set do not redirect.
* RegExp Redirects with a pattern not covering params
  and no GET arguments are given in the request uri but
  "Respect GET Parameters" has been set redirects to the
  target url.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk uploaded patch set 1 09/06/23, 20:18

  2. core-ci voted on patch set 1 V +1 09/06/23, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46305

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/06/23, 20:26

  4. Stefan Bürk merged patch set 2 09/06/23, 20:26