Review main Merged

80891[BUGFIX] Fix color picker in non-FormEngine context

Andreas Kienast CR +2 V +2 Easy +18 −15 updated 09/18/23, 09:02

Commit message

With migrating the color picker to alwan in #101646, the usage broke
for any case where the color picker was not used in FormEngine, e.g.
extension configuration. This patch moves some FormEngine-related code
into the `@typo3/backend/form-engine/element/color-element` module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 812

  1. Andreas Kienast uploaded patch set 1 09/07/23, 08:02

  2. core-ci voted on patch set 1 V +1 09/07/23, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46330

  3. Andreas Kienast voted on patch set 1 CR -1 09/14/23, 10:33

  4. Andreas Kienast uploaded patch set 2 CR -1 V +1 09/14/23, 10:43

  5. core-ci voted on patch set 2 V +1 09/14/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46573

  6. Andreas Kienast uploaded patch set 3 V +1 09/14/23, 10:53

  7. core-ci voted on patch set 3 V +1 09/14/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46574

  8. Andreas Kienast uploaded patch set 4 V +1 09/14/23, 12:57

  9. core-ci voted on patch set 4 V +1 09/14/23, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46580

  10. Benjamin Franzke commented on patch set 4 V +1 CR +1 09/18/23, 08:24

    color-element.ts:53

    I think we need to improve on the the usage of the "blur" event in general, which a bit "misused" for communication between visible/controls and hidden formengine fields For now I'm fine with this solution.
  11. Oli Bartsch voted on patch set 4 V +2 CR +2 09/18/23, 09:02

  12. Oli Bartsch merged patch set 5 09/18/23, 09:02