Review 12.4 Merged

80894[BUGFIX] Make WebserverType an optional argument

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 09/07/23, 10:03

Commit message

There is no downside in making the argument optional.
Although the API is marked as internal, it is in use
in third party code, which would break within a bugfix release.

Logically the API makes total sense with the argument
being optional. If the webserver type is not known or not
provided, no additional file is created.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 09/07/23, 09:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/07/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46337

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/07/23, 10:03

  4. Stefan Bürk merged patch set 2 09/07/23, 10:03