Review 12.4 Merged

80904[BUGFIX] Do not try to create symlinks on Windows

Benjamin Franzke CR +2 V +2 Easy +24 −4 updated 09/08/23, 11:35

Commit message

When a junction already exists on Windows, it is tried
to create a symlink, because of a missing OS check.

While this works as errors are ignored, it is
an unnecessary filesystem call.

Therefore the code is changed to only emit
the appropriate filesystem operations per OS.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 09/08/23, 11:26

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/08/23, 11:29

  3. core-ci voted on patch set 1 V +1 09/08/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46381

  4. Benjamin Franzke merged patch set 2 09/08/23, 11:35