Review 12.4 Merged

80906[BUGFIX] Respect crop of FileReference objects in getImgResource

Stefan Bürk CR +2 V +2 Easy +29 −1 updated 09/08/23, 15:06

Commit message

ContentObjectRenderer::getImgResource is used for the content objects
IMAGE, IMG_RESOURCE, as well as GIFBUILDER to process images.

When it is passed a FileReference object, it should respect the crop
settings of this reference, same as when it is passed a reference UID
plus the treatIdAsReference config.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Stefan Bürk commented on patch set 1 09/08/23, 14:51

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/08/23, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46398

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/08/23, 15:06

  4. Stefan Bürk merged patch set 2 09/08/23, 15:06