Review 11.5 Merged

80912[BUGFIX] Fix race condition in module router

Benjamin Franzke CR +2 V +2 Easy +9 −2 updated 09/07/23, 08:38

Commit message

The module components (like the iframe wrapper) are
created asynchronously after their implementing module
(e.g. <typo3-iframe-module>) is loaded.

The router had a preparatory check that verified
that existing module elements are reused, but missed
to verifiy whether the element has been created in
parallel while the module components javascript module
was loaded. This happens when the module changes
while the module component is loaded for the first time.

That leads to a situation that the module componenent
was created twice, which rendered two module frames
into the backend.

Also resolve a long overdue todo while at it.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2