Review main Merged

80913[TASK] Allow configuring the modal size via markup trigger

Andreas Kienast CR +2 V +2 Easy +7 −1 updated 09/07/23, 11:00

Commit message

When triggering modals via the `.t3js-modal-trigger` class, it is now
possible to configure a modal's size via the `data-size` attribute,
accepting all modal sizes:

* `small`
* `default`
* `medium`
* `large`
* `full`

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Andreas Kienast uploaded patch set 1 09/07/23, 08:45

  2. Georg Ringer commented on patch set 1 V +1 CR +1 09/07/23, 08:51

    awesome, thanks!
  3. core-ci voted on patch set 1 V +1 09/07/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46333

  4. Benjamin Franzke commented on patch set 1 09/07/23, 10:18

    modal.ts:496

    Just noticed, this can be expressed nicer via `as Sizes` (and yes, could be fixed aboth as well)
  5. Andreas Kienast commented on patch set 1 09/07/23, 10:24

    modal.ts:496 Reply

    Interestingly, this doesn't work for `SeverityEnum`: > TS2352: Conversion of type  string  to type  SeverityEnum  may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to  unknown  first.
  6. Benjamin Franzke commented on patch set 1 CR +1 09/07/23, 10:32

    modal.ts:496 Reply

    Ah, ok, so `keyof typeof Sizes` was fine as we really want the keys, not the values.
  7. Benjamin Franzke voted on patch set 1 V +1 09/07/23, 10:36

  8. Andreas Kienast voted on patch set 1 V +2 CR +2 09/07/23, 10:38

  9. Andreas Kienast merged patch set 2 09/07/23, 11:00