80913[TASK] Allow configuring the modal size via markup trigger
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Georg Ringer +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 2
Review log 89
-
Andreas Kienast uploaded patch set 1 09/07/23, 08:45
-
Georg Ringer commented on patch set 1 V +1 CR +1 09/07/23, 08:51
awesome, thanks! -
core-ci voted on patch set 1 V +1 09/07/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46333
-
Benjamin Franzke commented on patch set 1 09/07/23, 10:18
modal.ts:496Just noticed, this can be expressed nicer via `as Sizes` (and yes, could be fixed aboth as well) -
Andreas Kienast commented on patch set 1 09/07/23, 10:24
modal.ts:496ReplyInterestingly, this doesn't work for `SeverityEnum`: > TS2352: Conversion of type string to type SeverityEnum may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to unknown first. -
Benjamin Franzke commented on patch set 1 CR +1 09/07/23, 10:32
modal.ts:496ReplyAh, ok, so `keyof typeof Sizes` was fine as we really want the keys, not the values. -
Benjamin Franzke voted on patch set 1 V +1 09/07/23, 10:36
-
Andreas Kienast voted on patch set 1 V +2 CR +2 09/07/23, 10:38
-
Andreas Kienast merged patch set 2 09/07/23, 11:00