Review main Merged

80915[TASK] Simplify filesystem usage in PackageArtifactBuilder

Helmut Hummel CR +2 V +2 Easy +17 −13 updated 09/08/23, 06:14

Commit message

Only create one filesystem object,
instead of always creating new ones where needed.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Thomas Hohn +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Thomas Hohn +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Helmut Hummel uploaded patch set 1 09/07/23, 09:52

  2. Stefan Bürk commented on patch set 1 09/07/23, 09:59

    Can't we create the filesystem instance in the constructor and assign it to the property instead of doing that in multiple methods ?
  3. core-ci voted on patch set 1 V +1 09/07/23, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46338

  4. Helmut Hummel commented on patch set 1 09/07/23, 10:26

    Reply

    It is created in exactly one method, which is the one, that is called by Composer. Since PackageArtifactBuilder is a subclass of PackageManager, I do not want to do anything in the constructor
  5. Andreas Kienast voted on patch set 1 V +1 CR +1 09/07/23, 10:30

  6. Stefan Bürk commented on patch set 1 V +1 CR +1 09/07/23, 10:36

    Reply

    Eh right. my bad. Misread something.
  7. Thomas Hohn voted on patch set 1 V +1 CR +1 09/07/23, 10:40

  8. Helmut Hummel commented on patch set 1 V +2 CR +2 09/07/23, 11:03

    Thanks!
  9. Helmut Hummel merged patch set 2 09/07/23, 11:03

  10. Benjamin Franzke commented on patch set 2 09/08/23, 06:07

    Why has this not been backported to v11? The previous patch that is now cleaned-up by this and the followup task, was merged into v11: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75867 It should probably have been reverted to be honest – anyway, any reason not to cleanup v11?
  11. Benjamin Franzke commented on patch set 2 09/08/23, 06:14