Review 12.4 Merged

80917[TASK] Replace `php -S` with apache2 and php-fpm

Stefan Bürk CR +2 V +2 Normal +149 −31 updated 09/07/23, 14:00

Commit message

This change uses a slighty modified httpd (apache2)
image based on alpine along with a own php-fpm image
to spawn up a webserver with php-fpm in two containers
as a replacement for the `php -S` webserver used prior.

Modification for the apache2 (httpd) image are minimal
and gives us the ability to mount the project with the
exact same path in the image as from outside. Further
all required apache2 modules are loaded missing the
official image.

Due to moving away from the php webserver we now need
to adjust some configurations:

* Use port 80 instead of 8000 the for acceptance
  and acceptanceInstall tests webserver.
* Use the acceptance test instance as DocumentRoot
  instead of the monorepo root.
* Copy several `.htaccess` files to the acceptance
  test instance as we now have a real apache2.
* Copy the favicon.ico to the test instance instead
  of the monorepo root.
* Ensure that created frontend SiteConfiguration no
  longer uses the relative test instance path.
  Simply use `/`.
* Use only the php-fpm image for cli and webserver
  fpm container.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 711

  1. Stefan Bürk uploaded patch set 1 09/07/23, 10:10

  2. Stefan Bürk updated the commit message in patch set 2 09/07/23, 10:13

  3. Stefan Bürk wrote 09/07/23, 10:13

    Removed reviewer Christian Kuhn.
  4. core-ci voted on patch set 1 V +1 09/07/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46341

  5. core-ci voted on patch set 2 V +1 09/07/23, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46342

  6. core-ci commented on patch set 2 09/07/23, 10:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46343

  7. Stefan Bürk updated the commit message in patch set 3 V +1 09/07/23, 10:57

  8. core-ci voted on patch set 3 V +1 09/07/23, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46346

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 09/07/23, 13:58

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 09/07/23, 14:00

  11. Stefan Bürk merged patch set 4 09/07/23, 14:00