Review main Abandoned

80918[BUGFIX] Display error message when change password and event PasswordChangeEvent stops propagation

Florian Rival CR 0 V 0 Easy +4 −2 updated 01/08/25, 15:21

Commit message

Add the request mapping result to the forward action so that error messages added with addError() are displayed

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 89

  1. Florian Rival uploaded patch set 1 09/07/23, 12:09

  2. core-ci voted on patch set 1 V +1 09/07/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46349

  3. Markus Klein commented on patch set 1 09/07/23, 18:08

    Please create the patch against current main (v13 this is)

    Unresolved

    Must be: main, 12.4, 11.5
  4. Florian Rival commented on patch set 1 09/08/23, 09:32

    Reply

    I see in the TYPO3 V13 doc https://docs.typo3.org/m/typo3/reference-coreapi/12.4/en-us/ApiOverview/Events/Events/FrontendLogin/PasswordChangeEvent.html Deprecated since version 12.4: The PasswordChangeEvent should not be used to validate user passwords, since it is not possible to visualize to the user why a password has been rejected. Therefore the following methods of the event are deprecated. This fix correct this bug. The possibility to stop password change shouldn't disappear because it very useful and there is no real replacement because it could be used for example to change the password on a third-part application - this is my case - and a replacement with a custom validator is something different.
  5. Benni Mack commented on patch set 1 12/04/24, 09:59

    Reply

    any update on this patch? AFAICS this only affects v12 now.
  6. Markus Klein commented on patch set 1 12/05/24, 11:56

    Reply

    It should be fixed in v12, as it's an easy one. Regarding the use case of @florian.typo3@oktopuce.fr: I think it should be possible to achieve this also with a custom validator. If not, please open a separate ticket for v14+v13 then.
  7. Markus Klein commented on patch set 1 12/05/24, 11:58

  8. Torben Hansen commented on patch set 1 12/05/24, 14:31

    Reply

    Yes, the requirement should be possible with a custom password policy validator and with the `PasswordChangeEvent` which is dispatched after the password has been changed in TYPO3.
  9. Garvin Hicking abandoned the change 01/08/25, 15:21

    https://review.typo3.org/c/Packages/TYPO3.CMS/+/87374 targets the proper 12.4 release, 11.5 is beyond scope for this