Review main Merged

80919[TASK] Unify table sort rendering

Benjamin Kott CR +2 V +2 Hard +184 −74 updated 09/11/23, 10:03

Commit message

Use actions-sort-* icons for table
sorting and use accessible elements (button/a)
in sorting triggers.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1118

  1. Benjamin Kott uploaded patch set 1 09/07/23, 14:44

  2. core-ci voted on patch set 1 V -1 09/07/23, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46355

  3. Benjamin Kott uploaded patch set 2 V -1 09/08/23, 11:57

  4. Benjamin Kott rebased onto patch set 3 09/08/23, 11:57

  5. Benjamin Kott uploaded patch set 4 09/08/23, 12:07

  6. core-ci voted on patch set 3 V -1 09/08/23, 12:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46384

  7. core-ci voted on patch set 2 V -1 09/08/23, 12:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46383

  8. core-ci voted on patch set 4 V -1 09/08/23, 12:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46385

  9. Benjamin Kott uploaded patch set 5 V -1 09/08/23, 12:59

  10. core-ci voted on patch set 5 V +1 09/08/23, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46393

  11. Benjamin Franzke commented on patch set 5 CR -1 09/08/23, 13:16

    on it
  12. Benjamin Franzke uploaded patch set 6 CR -1 V +1 09/08/23, 13:27

  13. core-ci voted on patch set 6 V +1 09/08/23, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46396

  14. Benjamin Franzke uploaded patch set 7 CR +1 V +1 09/09/23, 16:36

  15. core-ci voted on patch set 7 V +1 09/09/23, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46430

  16. Benni Mack voted on patch set 7 V +1 CR +1 09/11/23, 09:16

  17. Benjamin Franzke voted on patch set 7 V +2 CR +2 09/11/23, 09:30

  18. Benjamin Franzke merged patch set 8 09/11/23, 10:03